Skip to content

Conversation

@BabyBhargaviAnde
Copy link
Collaborator

@BabyBhargaviAnde BabyBhargaviAnde commented Oct 9, 2025

Hi @irfanshar,
I have updated all the Flags in def_rules.mk to address the apostrophe issue. Could you please review the changes and let me know if anything else needs to be modified.
image

@BabyBhargaviAnde BabyBhargaviAnde linked an issue Oct 10, 2025 that may be closed by this pull request
Signed-off-by: Bharghavi-Ande-Baby <bhargavi.ande1@gmail.com>
Signed-off-by: Bharghavi-Ande-Baby <bhargavi.ande1@gmail.com>
@hetpatelibm
Copy link
Collaborator

Hi @BabyBhargaviAnde ,
Could you please check the conflicts, which this branch is having?

@BabyBhargaviAnde
Copy link
Collaborator Author

Hi @hetpatelibm,
I have resolved the conflicts on this branch. Could you please review.

Copy link
Collaborator

@hetpatelibm hetpatelibm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@hetpatelibm hetpatelibm merged commit 2c5ad68 into master Nov 24, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

%METADATA %TEXT fails with apostrophe

3 participants